Switch to using accessibilityEnabled and inlineTextBoxAccessibilityEnabled from settings

Source/core/accessibility/AXNodeObject.cpp

 /*
 * Copyright (C) 2012, Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 14 matching lines @@
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
 #include "config.h"
 #include "core/accessibility/AXNodeObject.h"
 
 #include "core/accessibility/AXObjectCache.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/Text.h"
+#include "core/frame/Settings.h"
 #include "core/html/HTMLFieldSetElement.h"
 #include "core/html/HTMLFrameElementBase.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLLabelElement.h"
 #include "core/html/HTMLLegendElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/HTMLSelectElement.h"
 #include "core/html/HTMLTextAreaElement.h"
 #include "core/rendering/RenderObject.h"
 #include "platform/UserGestureIndicator.h"
@@ skipping 1344 matching lines @@
     case ButtonRole:
     case PopUpButtonRole:
     case CheckBoxRole:
     case RadioButtonRole:
     case TabRole:
     case ToggleButtonRole:
     case ListBoxOptionRole:
     case ScrollBarRole:
         return false;
     case StaticTextRole:
-        if (!axObjectCache()->inlineTextBoxAccessibility())
+        if (!document()->settings() || !document()->settings()->inlineTextBoxAccessibilityEnabled())

[dmazzoni, 2014/08/23 05:36:01]

I think it might be cleaner to implement convenience functions for this within
accessibility:

* It eliminates the need to include core/frame/Settings.h from more files, which
will hopefully save some recompiles
* It makes negating the test easier and more readable

Either move it back to AXObjectCache, or maybe implement it as a protected
method in AXObject.

[aboxhall, 2014/08/27 15:26:33]

Good idea, done.

             return false;
     default:
         return true;
     }
 }
 
 Element* AXNodeObject::actionElement() const
 {
     Node* node = this->node();
     if (!node)
@@ skipping 294 matching lines @@
     float range = maxValueForRange() - minValueForRange();
     float value = valueForRange();
 
     value += range * (percentChange / 100);
     setValue(String::number(value));
 
     axObjectCache()->postNotification(node(), AXObjectCache::AXValueChanged, true);
 }
 
 } // namespace blink