Remove bluez header includes from Chromium. Instead, replicate a few declarations inline.

Remove bluez header includes from Chromium. Instead, replicate a few declarations inline.

BUG=387122
TEST=none
R=keybuk@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291245

[keybuk, 2014-08-21 16:56:25]

https://codereview.chromium.org/495763004/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_bluetooth_util_chromeos.cc
(right):

https://codereview.chromium.org/495763004/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_bluetooth_util_chromeos.cc:105:
addr.l2_psm = base::ByteSwapToLE16(SDP_PSM);
Are these really equivalent?

htobs() conditionally swaps bytes, while it sounds like ByteSwapToLE16 might
always swap them

[Ilya Sherman, 2014-08-21 17:03:13]

https://codereview.chromium.org/495763004/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_bluetooth_util_chromeos.cc
(right):

https://codereview.chromium.org/495763004/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_bluetooth_util_chromeos.cc:105:
addr.l2_psm = base::ByteSwapToLE16(SDP_PSM);
On 2014/08/21 16:56:25, keybuk wrote:
> Are these really equivalent?
> 
> htobs() conditionally swaps bytes, while it sounds like ByteSwapToLE16 might
> always swap them

ByteSwapToLE16 is also conditional:
https://code.google.com/p/chromium/codesearch#chromium/src/base/sys_byteorder...

That said, let me know if you'd prefer me to restore the use of htobs() here.

[keybuk, 2014-08-21 17:19:18]

lgtm

[Ilya Sherman, 2014-08-21 17:21:39]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2014-08-21 17:21:41]

The CQ bit was unchecked by isherman@chromium.org

[Ilya Sherman, 2014-08-21 17:21:57]

+Tim for OWNERS approval

[Tim Song, 2014-08-21 17:43:48]

lgtm

[Ilya Sherman, 2014-08-21 17:58:30]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-08-21 18:01:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/isherman@chromium.org/495763004/1

[commit-bot: I haz the power, 2014-08-21 23:37:31]

Committed patchset #1 (1) as 291245