Source/web/WebLocalFrameImpl.cpp - Issue 495743003: Add an extra guard to replaceDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 495743003: Add an extra guard to replaceDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Landing Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index b29dbe64f152eed6977f8b870b52a81721fceff3..a713db687284ea41e728dcd9f28891a755c26ad8 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -1803,7 +1803,7 @@ void WebLocalFrameImpl::loadJavaScriptURL(const KURL& url)

return;

String scriptResult = toCoreString(v8::Handle<v8::String>::Cast(result));

if (!frame()->navigationScheduler().locationChangePending())

- frame()->document()->loader()->replaceDocument(scriptResult, ownerDocument.get());

+ frame()->loader().replaceDocumentWhileExecutingJavaScriptURL(scriptResult, ownerDocument.get());

}

void WebLocalFrameImpl::addStyleSheetByURL(const WebString& url)

« no previous file with comments | « Source/core/loader/FrameLoader.cpp ('k') | no next file » | no next file with comments »