Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: Source/core/dom/DocumentParser.h

Issue 495743003: Add an extra guard to replaceDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Landing Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/DocumentInit.cpp ('k') | Source/core/frame/LocalFrame.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Peter Kelly (pmk@post.com) 2 * Copyright (C) 2000 Peter Kelly (pmk@post.com)
3 * Copyright (C) 2005, 2006 Apple Computer, Inc. 3 * Copyright (C) 2005, 2006 Apple Computer, Inc.
4 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 4 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
5 * Copyright (C) 2010 Google, Inc. 5 * Copyright (C) 2010 Google, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 // The below functions are used by DocumentWriter (the loader). 51 // The below functions are used by DocumentWriter (the loader).
52 virtual void appendBytes(const char* bytes, size_t length) = 0; 52 virtual void appendBytes(const char* bytes, size_t length) = 0;
53 virtual bool needsDecoder() const { return false; } 53 virtual bool needsDecoder() const { return false; }
54 virtual void setDecoder(PassOwnPtr<TextResourceDecoder>); 54 virtual void setDecoder(PassOwnPtr<TextResourceDecoder>);
55 virtual TextResourceDecoder* decoder(); 55 virtual TextResourceDecoder* decoder();
56 virtual void setHasAppendedData() { } 56 virtual void setHasAppendedData() { }
57 57
58 // pinToMainThread also makes append() not yield before completion of that c hunk. 58 // pinToMainThread also makes append() not yield before completion of that c hunk.
59 virtual void pinToMainThread() { } 59 virtual void pinToMainThread() { }
60 60
61 // FIXME: append() should be private, but DocumentWriter::replaceDocument us es it for now. 61 // FIXME: append() should be private, but DocumentWriter::replaceDocumentWhi leExecutingJavaScriptURL uses it for now.
62 // FIXME: This really should take a PassOwnPtr to signify that it expects to take 62 // FIXME: This really should take a PassOwnPtr to signify that it expects to take
63 // ownership of the buffer. The parser expects the PassRefPtr to hold the on ly ref of the StringImpl. 63 // ownership of the buffer. The parser expects the PassRefPtr to hold the on ly ref of the StringImpl.
64 virtual void append(PassRefPtr<StringImpl>) = 0; 64 virtual void append(PassRefPtr<StringImpl>) = 0;
65 65
66 virtual void finish() = 0; 66 virtual void finish() = 0;
67 67
68 // FIXME: processingData() is only used by DocumentLoader::isLoadingInAPISen se 68 // FIXME: processingData() is only used by DocumentLoader::isLoadingInAPISen se
69 // and is very unclear as to what it actually means. The LegacyHTMLDocument Parser 69 // and is very unclear as to what it actually means. The LegacyHTMLDocument Parser
70 // used to implement it. 70 // used to implement it.
71 virtual bool processingData() const { return false; } 71 virtual bool processingData() const { return false; }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 bool m_documentWasLoadedAsPartOfNavigation; 119 bool m_documentWasLoadedAsPartOfNavigation;
120 120
121 // Every DocumentParser needs a pointer back to the document. 121 // Every DocumentParser needs a pointer back to the document.
122 // m_document will be 0 after the parser is stopped. 122 // m_document will be 0 after the parser is stopped.
123 RawPtrWillBeMember<Document> m_document; 123 RawPtrWillBeMember<Document> m_document;
124 }; 124 };
125 125
126 } // namespace blink 126 } // namespace blink
127 127
128 #endif // DocumentParser_h 128 #endif // DocumentParser_h
OLDNEW
« no previous file with comments | « Source/core/dom/DocumentInit.cpp ('k') | Source/core/frame/LocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698