Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/analysis_server/lib/src/services/correction/source_buffer.dart

Issue 495733002: Don't use LinkedEditGroup.id. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/correction/source_buffer.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/source_buffer.dart b/pkg/analysis_server/lib/src/services/correction/source_buffer.dart
index f635b35a28a234a805d30fd36e6af35b56d6822f..48510f07ba77e364b3cc9dd79841d7c9f598388e 100644
--- a/pkg/analysis_server/lib/src/services/correction/source_buffer.dart
+++ b/pkg/analysis_server/lib/src/services/correction/source_buffer.dart
@@ -16,7 +16,8 @@ class SourceBuilder {
final int offset;
final StringBuffer _buffer = new StringBuffer();
- final List<LinkedEditGroup> linkedPositionGroups = <LinkedEditGroup>[];
+ final Map<String, LinkedEditGroup> linkedPositionGroups = <String,
+ LinkedEditGroup>{};
LinkedEditGroup _currentLinkedPositionGroup;
int _currentPositionStart;
int _exitOffset;
@@ -75,17 +76,12 @@ class SourceBuilder {
/**
* Marks start of a new linked position for the group with the given ID.
*/
- void startPosition(String groupId) {
+ void startPosition(String id) {
assert(_currentLinkedPositionGroup == null);
- for (LinkedEditGroup position in linkedPositionGroups) {
- if (position.id == groupId) {
- _currentLinkedPositionGroup = position;
- break;
- }
- }
+ _currentLinkedPositionGroup = linkedPositionGroups[id];
if (_currentLinkedPositionGroup == null) {
- _currentLinkedPositionGroup = new LinkedEditGroup(groupId);
- linkedPositionGroups.add(_currentLinkedPositionGroup);
+ _currentLinkedPositionGroup = new LinkedEditGroup();
+ linkedPositionGroups[id] = _currentLinkedPositionGroup;
}
_currentPositionStart = _buffer.length;
}

Powered by Google App Engine
This is Rietveld 408576698