Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 495723002: Add "Always Run" menu item for script injection requests on Mac (Closed)

Created:
6 years, 4 months ago by gpdavis
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, not at google - send to devlin, Devlin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add "Always Run" menu item for script injection requests on Mac BUG=405682 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm View 4 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
gpdavis
The purpose of this CL is to add functionality from https://codereview.chromium.org/396033002/ to the cocoa extension ...
6 years, 4 months ago (2014-08-20 21:09:06 UTC) #1
Alexei Svitkine (slow)
Can you have the reviewers of the other CL take a look at this first ...
6 years, 4 months ago (2014-08-20 21:23:32 UTC) #2
gpdavis
On 2014/08/20 21:23:32, Alexei Svitkine wrote: > Can you have the reviewers of the other ...
6 years, 4 months ago (2014-08-20 21:31:56 UTC) #3
Devlin
lgtm
6 years, 4 months ago (2014-08-20 21:40:00 UTC) #4
gpdavis
On 2014/08/20 21:40:00, Devlin wrote: > lgtm asvitkine@, PTAL :)
6 years, 4 months ago (2014-08-20 23:24:38 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years, 4 months ago (2014-08-21 00:06:07 UTC) #6
gpdavis
The CQ bit was checked by gpdavis.chromium@gmail.com
6 years, 4 months ago (2014-08-21 17:05:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gpdavis.chromium@gmail.com/495723002/1
6 years, 4 months ago (2014-08-21 17:08:23 UTC) #8
gpdavis
The CQ bit was unchecked by gpdavis.chromium@gmail.com
6 years, 4 months ago (2014-08-21 21:26:17 UTC) #9
gpdavis
The CQ bit was checked by gpdavis.chromium@gmail.com
6 years, 4 months ago (2014-08-21 21:26:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gpdavis.chromium@gmail.com/495723002/1
6 years, 4 months ago (2014-08-21 21:27:18 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 23:08:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 291228

Powered by Google App Engine
This is Rietveld 408576698