Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2847)

Unified Diff: chrome/browser/profile_resetter/profile_resetter.cc

Issue 495643002: Trigger the SW reporter to run once a week for users with UMA enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Responding to comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_accessor.h ('k') | components/component_updater/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profile_resetter/profile_resetter.cc
diff --git a/chrome/browser/profile_resetter/profile_resetter.cc b/chrome/browser/profile_resetter/profile_resetter.cc
index 0bc7cdc3c0dc6decbec1868f347bcbc71658c195..600fc6a6f6487953b770d55580dddaf104b46673 100644
--- a/chrome/browser/profile_resetter/profile_resetter.cc
+++ b/chrome/browser/profile_resetter/profile_resetter.cc
@@ -34,7 +34,6 @@
#if defined(OS_WIN)
#include "base/base_paths.h"
#include "base/path_service.h"
-#include "chrome/browser/component_updater/sw_reporter_installer_win.h"
MAD 2014/08/22 18:14:51 You should also be able to remove #include "chrom
csharp 2014/08/22 19:39:22 Done.
#include "chrome/installer/util/shell_util.h"
namespace {
@@ -126,20 +125,6 @@ void ProfileResetter::Reset(
}
}
-// When the user resets any of their settings on Windows and agreed to sending
-// feedback, run the software reporter tool to see if it could find the reason
-// why the user wanted a reset.
-#if defined(OS_WIN)
- // The browser process and / or local_state can be NULL when running tests.
- if (accepted_send_feedback && g_browser_process &&
- g_browser_process->local_state() &&
- g_browser_process->local_state()->GetBoolean(
- prefs::kMetricsReportingEnabled)) {
- ExecuteSwReporter(g_browser_process->component_updater(),
- g_browser_process->local_state());
- }
-#endif
-
waffles 2014/08/22 18:52:53 With this code now gone, how does a user initially
MAD 2014/08/22 19:02:09 ExecuteSwReporter is now called when it wasn't cal
DCHECK_EQ(resettable_flags, reset_triggered_for_flags);
}
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_accessor.h ('k') | components/component_updater/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698