Add checking queue size when calling handleSpeakingCompleted().

Add checking queue size when calling handleSpeakingCompleted().

Some speech contents are not removed when is called by async.
In this case, when call to speak() function twice, second data is not removed in queue.

So I add routine in handleSpeakingCompleted() that is start to speak() function immediately when latest queue size is not 0.
It also works fine if called by asynchronous repeatedly.
BUG=405585
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180813

[deejay, 2014-08-21 00:40:18]

PTAL

[haraken, 2014-08-21 01:01:22]

https://codereview.chromium.org/495603002/diff/1/Source/modules/speech/Speech...
File Source/modules/speech/SpeechSynthesis.cpp (right):

https://codereview.chromium.org/495603002/diff/1/Source/modules/speech/Speech...
Source/modules/speech/SpeechSynthesis.cpp:157: int oldQueueSize = 0;

Can we introduce something like a |shouldStartSpeaking| flag and remove
|didJustFinishCurrentUtterance| and |oldQueueSize|?

bool shouldStartSpeaking = false;
if (utterance == currentSpeechUtterance()) {
  m_utteranceQueue.removeFirst();
  shouldStartSpeaking = !!m_utteranceQueue.size();
}

[deejay, 2014-08-21 13:19:00]

On 2014/08/21 01:01:22, haraken wrote:
>
https://codereview.chromium.org/495603002/diff/1/Source/modules/speech/Speech...
> File Source/modules/speech/SpeechSynthesis.cpp (right):
> 
>
https://codereview.chromium.org/495603002/diff/1/Source/modules/speech/Speech...
> Source/modules/speech/SpeechSynthesis.cpp:157: int oldQueueSize = 0;
> 
> Can we introduce something like a |shouldStartSpeaking| flag and remove
> |didJustFinishCurrentUtterance| and |oldQueueSize|?
> 
> bool shouldStartSpeaking = false;
> if (utterance == currentSpeechUtterance()) {
>   m_utteranceQueue.removeFirst();
>   shouldStartSpeaking = !!m_utteranceQueue.size();
> }

I agree your opinion. "didJustFinishCurrentUtterance" flag is not needed.
Now I upload new patch. could you check it?

[haraken, 2014-08-21 14:26:46]

LGTM

[deejay, 2014-08-21 17:35:36]

The CQ bit was checked by djmix.kim@samsung.com

[commit-bot: I haz the power, 2014-08-21 17:36:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/djmix.kim@samsung.com/495603002/20001

[commit-bot: I haz the power, 2014-08-21 21:28:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-08-21 21:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 21:40:03]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[deejay, 2014-08-22 05:04:38]

The CQ bit was checked by djmix.kim@samsung.com

[commit-bot: I haz the power, 2014-08-22 05:05:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/djmix.kim@samsung.com/495603002/20001

[commit-bot: I haz the power, 2014-08-22 05:07:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[commit-bot: I haz the power, 2014-08-22 05:09:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 05:09:59]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[deejay, 2014-08-22 12:42:46]

The CQ bit was checked by djmix.kim@samsung.com

[commit-bot: I haz the power, 2014-08-22 12:42:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/djmix.kim@samsung.com/495603002/20001

[commit-bot: I haz the power, 2014-08-22 12:45:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[commit-bot: I haz the power, 2014-08-22 12:47:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 12:47:35]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[deejay, 2014-08-23 03:05:06]

The CQ bit was checked by djmix.kim@samsung.com

[commit-bot: I haz the power, 2014-08-23 03:05:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/djmix.kim@samsung.com/495603002/20001

[commit-bot: I haz the power, 2014-08-24 04:46:43]

Committed patchset #2 (20001) as 180813