chromeos/ime/component_extension_ime_manager.cc - Issue 495593004: Check the IME component extension's availability on linux_chromeos, so that system fallback VK can …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/ime/component_extension_ime_manager.cc

Issue 495593004: Check the IME component extension's availability on linux_chromeos, so that system fallback VK can … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revised per comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc ('K') | « chromeos/ime/component_extension_ime_manager.h ('k') | chromeos/ime/mock_component_extension_ime_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/ime/component_extension_ime_manager.cc

diff --git a/chromeos/ime/component_extension_ime_manager.cc b/chromeos/ime/component_extension_ime_manager.cc

index cd6ebd5812b82da4ad69de2e61d054e04bb74503..feb03477188c45b3fc18a966aacb1ae1f5d3cbba 100644

--- a/chromeos/ime/component_extension_ime_manager.cc

+++ b/chromeos/ime/component_extension_ime_manager.cc

@@ -108,10 +108,11 @@ bool ComponentExtensionIMEManager::LoadComponentExtensionIME(

Profile* profile,

const std::string& input_method_id) {

ComponentExtensionIME ime;

- if (FindEngineEntry(input_method_id, &ime))

- return delegate_->Load(profile, ime.id, ime.manifest, ime.path);

- else

- return false;

+ if (FindEngineEntry(input_method_id, &ime)) {

+ delegate_->Load(profile, ime.id, ime.manifest, ime.path);

+ return true;

+ }

+ return false;

}

bool ComponentExtensionIMEManager::UnloadComponentExtensionIME(