chrome/browser/sync/sessions/sessions_sync_manager.h - Issue 495593003: Avoid memory corruption in sessions sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sessions/sessions_sync_manager.h

Issue 495593003: Avoid memory corruption in sessions sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/sessions/sessions_sync_manager.h

diff --git a/chrome/browser/sync/sessions/sessions_sync_manager.h b/chrome/browser/sync/sessions/sessions_sync_manager.h

index c92c58873f17c564c019c2ad4d99207586174289..92dc1e67cf2aceb844b2789dd9d2bb8a050fac53 100644

--- a/chrome/browser/sync/sessions/sessions_sync_manager.h

+++ b/chrome/browser/sync/sessions/sessions_sync_manager.h

@@ -323,6 +323,10 @@ class SessionsSyncManager : public syncer::SyncableService,

// See |local_tab_pool_out_of_sync_|.

void RebuildAssociations();

+ // Validates the content of a SessionHeader protobuf.

+ // Returns false if validation fails.

+ static bool IsValidSessionHeader(const sync_pb::SessionHeader& header);

// Mapping of current open (local) tabs to their sync identifiers.

TabLinksMap local_tab_map_;