Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 495563003: Move ParallelAuthnticator to chromeos and rename it to CryptohomeAuthenticator (Closed)

Created:
6 years, 4 months ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 4 months ago
Reviewers:
stevenjb, Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move ParallelAuthnticator to chromeos and rename it to CryptohomeAuthenticator BUG=387613 R=nkostylev@chromium.org TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291125

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fix nits #

Patch Set 3 : Merge with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -2169 lines) Patch
A chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc View 30 chunks +114 lines, -121 lines 0 comments Download
M chrome/browser/chromeos/login/auth/login_performer.h View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/chromeos/login/auth/parallel_authenticator.h View 1 chunk +0 lines, -250 lines 0 comments Download
D chrome/browser/chromeos/login/auth/parallel_authenticator.cc View 1 chunk +0 lines, -818 lines 0 comments Download
D chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc View 1 chunk +0 lines, -744 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + chromeos/login/auth/cryptohome_authenticator.h View 1 10 chunks +40 lines, -21 lines 0 comments Download
A + chromeos/login/auth/cryptohome_authenticator.cc View 1 32 chunks +147 lines, -208 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Denis Kuznetsov (DE-MUC)
Nikita as the main reviewer, Steven for rubber-stamping profile_helper and *.gyp changes.
6 years, 4 months ago (2014-08-20 18:51:19 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/495563003/diff/1/chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h File chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h (right): https://codereview.chromium.org/495563003/diff/1/chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h#newcode5 chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h:5: #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_AUTH_PARALLEL_AUTHENTICATOR_H_ nit: Update guard https://codereview.chromium.org/495563003/diff/1/chromeos/login/auth/cryptohome_authenticator.cc File chromeos/login/auth/cryptohome_authenticator.cc ...
6 years, 4 months ago (2014-08-21 10:55:25 UTC) #2
Denis Kuznetsov (DE-MUC)
https://codereview.chromium.org/495563003/diff/1/chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h File chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h (right): https://codereview.chromium.org/495563003/diff/1/chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h#newcode5 chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.h:5: #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_AUTH_PARALLEL_AUTHENTICATOR_H_ On 2014/08/21 10:55:24, Nikita (OOO Aug 22 ...
6 years, 4 months ago (2014-08-21 11:22:03 UTC) #3
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 4 months ago (2014-08-21 14:07:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/495563003/40001
6 years, 4 months ago (2014-08-21 14:08:20 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 17:30:20 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 291125

Powered by Google App Engine
This is Rietveld 408576698