Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 495553002: Remove unused error codes and fix mapping of weak DH key. (Closed)

Created:
6 years, 4 months ago by haavardm
Modified:
6 years, 4 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix mapping of weak DH key and remove unused error codes. None of these error codes are actually reported back by BoringSSL. SSL_R_WRONG_NUMBER_OF_KEY_BITS is changed to the proper error code SSL_R_BAD_DH_P_LENGTH. Test DH issue by loading https://demo.cmrg.net/ BUG=353579 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M net/ssl/openssl_ssl_util.cc View 4 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haavardm
agl, please review.
6 years, 4 months ago (2014-08-20 15:12:28 UTC) #1
agl
lgtm
6 years, 4 months ago (2014-08-20 20:08:54 UTC) #2
agl
The CQ bit was checked by agl@chromium.org
6 years, 4 months ago (2014-08-20 20:08:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haavardm@opera.com/495553002/1
6 years, 4 months ago (2014-08-20 20:10:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 21:58:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 22:01:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55152) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/7947)
6 years, 4 months ago (2014-08-20 22:01:18 UTC) #7
haavardm
The CQ bit was checked by haavardm@opera.com
6 years, 4 months ago (2014-08-21 06:32:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haavardm@opera.com/495553002/1
6 years, 4 months ago (2014-08-21 06:33:59 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 12:07:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 291051

Powered by Google App Engine
This is Rietveld 408576698