Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: net/base/sdch_dictionary_fetcher_unittest.cc

Issue 495523003: Change SDCHDictionaryFetcher to use URLRequest instead of URLFetcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed try job failures. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/sdch_dictionary_fetcher.cc ('k') | net/base/sdch_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/sdch_dictionary_fetcher_unittest.cc
diff --git a/net/base/sdch_dictionary_fetcher_unittest.cc b/net/base/sdch_dictionary_fetcher_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..09155b81ccc014ee4923e47c9146d15394a25471
--- /dev/null
+++ b/net/base/sdch_dictionary_fetcher_unittest.cc
@@ -0,0 +1,193 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/base/sdch_dictionary_fetcher.h"
+
+#include <string>
+
+#include "base/run_loop.h"
+#include "base/strings/stringprintf.h"
+#include "base/thread_task_runner_handle.h"
+#include "net/base/sdch_manager.h"
+#include "net/url_request/url_request_data_job.h"
+#include "net/url_request/url_request_filter.h"
+#include "net/url_request/url_request_interceptor.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
+
+namespace net {
+
+static const char* kSampleBufferContext = "This is a sample buffer.";
+static const char* kTestDomain = "top.domain.test";
+
+class URLRequestSpecifiedResponseJob : public URLRequestSimpleJob {
+ public:
+ URLRequestSpecifiedResponseJob(URLRequest* request,
+ NetworkDelegate* network_delegate)
+ : URLRequestSimpleJob(request, network_delegate) {}
+
+ static void AddUrlHandler() {
+ net::URLRequestFilter* filter = net::URLRequestFilter::GetInstance();
+ jobs_requested_ = 0;
+ filter->AddHostnameHandler("http", kTestDomain,
+ &URLRequestSpecifiedResponseJob::Factory);
+ }
+
+ static void RemoveUrlHandler() {
+ net::URLRequestFilter* filter = net::URLRequestFilter::GetInstance();
+ filter->RemoveHostnameHandler("http", kTestDomain);
+ jobs_requested_ = 0;
+ }
+
+ static URLRequestJob* Factory(
+ URLRequest* request,
+ net::NetworkDelegate* network_delegate,
+ const std::string& scheme) {
+ ++jobs_requested_;
+ return new URLRequestSpecifiedResponseJob(request, network_delegate);
+ }
+
+ static std::string ExpectedResponseForURL(const GURL& url) {
+ return base::StringPrintf("Response for %s\n%s\nEnd Response for %s\n",
+ url.spec().c_str(), kSampleBufferContext,
+ url.spec().c_str());
+ }
+
+ static int jobs_requested() { return jobs_requested_; }
+
+ private:
+ virtual ~URLRequestSpecifiedResponseJob() {};
+ virtual int GetData(std::string* mime_type,
+ std::string* charset,
+ std::string* data,
+ const CompletionCallback& callback) const OVERRIDE {
+ GURL url(request_->url());
+ *data = ExpectedResponseForURL(url);
+ return OK;
+ }
+
+ static int jobs_requested_;
+};
+
+int URLRequestSpecifiedResponseJob::jobs_requested_(0);
+
+class SdchTestDelegate : public SdchFetcher::Delegate {
+ public:
+ struct DictionaryAdditions {
+ DictionaryAdditions(const std::string& dictionary_text,
+ const GURL& dictionary_url)
+ : dictionary_text(dictionary_text),
+ dictionary_url(dictionary_url) {}
+
+
+ std::string dictionary_text;
+ GURL dictionary_url;
+ };
+
+ virtual void AddSdchDictionary(const std::string& dictionary_text,
+ const GURL& dictionary_url) OVERRIDE {
+ dictionary_additions.push_back(
+ DictionaryAdditions(dictionary_text, dictionary_url));
+ }
+
+ void GetDictionaryAdditions(std::vector<DictionaryAdditions>* out) {
+ out->swap(dictionary_additions);
+ dictionary_additions.clear();
+ }
+
+ private:
+ std::vector<DictionaryAdditions> dictionary_additions;
+};
+
+class SdchDictionaryFetcherTest : public ::testing::Test {
+ public:
+ SdchDictionaryFetcherTest() {}
+
+ virtual void SetUp() OVERRIDE {
+ DCHECK(!fetcher_.get());
+
+ URLRequestSpecifiedResponseJob::AddUrlHandler();
+ fetcher_delegate_.reset(new SdchTestDelegate);
+ context_.reset(new TestURLRequestContext);
+ fetcher_.reset(new SdchDictionaryFetcher(
+ fetcher_delegate_.get(), context_.get()));
+ }
+
+ virtual void TearDown() OVERRIDE {
+ URLRequestSpecifiedResponseJob::RemoveUrlHandler();
+ fetcher_.reset();
+ context_.reset();
+ fetcher_delegate_.reset();
+ }
+
+ SdchDictionaryFetcher* fetcher() { return fetcher_.get(); }
+ SdchTestDelegate* manager() { return fetcher_delegate_.get(); }
+
+ // May not be called outside the SetUp()/TearDown() interval.
+ int JobsRequested() {
+ return URLRequestSpecifiedResponseJob::jobs_requested();
+ }
+
+ GURL PathToGurl(const char* path) {
+ std::string gurl_string("http://");
+ gurl_string += kTestDomain;
+ gurl_string += "/";
+ gurl_string += path;
+ return GURL(gurl_string);
+ }
+
+ private:
+ scoped_ptr<SdchTestDelegate> fetcher_delegate_;
+ scoped_ptr<TestURLRequestContext> context_;
+ scoped_ptr<SdchDictionaryFetcher> fetcher_;
+};
+
+// Schedule a fetch and make sure it happens.
+TEST_F(SdchDictionaryFetcherTest, Basic) {
+ GURL dictionary_url(PathToGurl("dictionary"));
+ fetcher()->Schedule(dictionary_url);
+
+ base::RunLoop().RunUntilIdle();
+ EXPECT_EQ(1, JobsRequested());
+ std::vector<SdchTestDelegate::DictionaryAdditions> additions;
+ manager()->GetDictionaryAdditions(&additions);
+ ASSERT_EQ(1u, additions.size());
+ EXPECT_EQ(URLRequestSpecifiedResponseJob::ExpectedResponseForURL(
+ dictionary_url), additions[0].dictionary_text);
+}
+
+// Multiple fetches of the same URL should result in only one request.
+TEST_F(SdchDictionaryFetcherTest, Multiple) {
+ GURL dictionary_url(PathToGurl("dictionary"));
+ fetcher()->Schedule(dictionary_url);
+ fetcher()->Schedule(dictionary_url);
+ fetcher()->Schedule(dictionary_url);
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(1, JobsRequested());
+ std::vector<SdchTestDelegate::DictionaryAdditions> additions;
+ manager()->GetDictionaryAdditions(&additions);
+ ASSERT_EQ(1u, additions.size());
+ EXPECT_EQ(URLRequestSpecifiedResponseJob::ExpectedResponseForURL(
+ dictionary_url), additions[0].dictionary_text);
+}
+
+// A cancel should result in no actual requests being generated.
+TEST_F(SdchDictionaryFetcherTest, Cancel) {
+ GURL dictionary_url_1(PathToGurl("dictionary_1"));
+ GURL dictionary_url_2(PathToGurl("dictionary_2"));
+ GURL dictionary_url_3(PathToGurl("dictionary_3"));
+
+ fetcher()->Schedule(dictionary_url_1);
+ fetcher()->Schedule(dictionary_url_2);
+ fetcher()->Schedule(dictionary_url_3);
+ fetcher()->Cancel();
+ base::RunLoop().RunUntilIdle();
+
+ // Synchronous execution may have resulted in a single job being scheduled.
+ EXPECT_GE(1, JobsRequested());
+}
+
+}
« no previous file with comments | « net/base/sdch_dictionary_fetcher.cc ('k') | net/base/sdch_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698