Change SDCHDictionaryFetcher to use URLRequest instead of URLFetcher.

net/base/sdch_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Provides global database of differential decompression dictionaries for the
 // SDCH filter (processes sdch enconded content).
 
 // Exactly one instance of SdchManager is built, and all references are made
 // into that collection.
 //
@@ skipping 219 matching lines @@
     // of the dictionary.  The following are the known headers.
     const std::string domain_;
     const std::string path_;
     const base::Time expiration_;  // Implied by max-age.
     const std::set<int> ports_;
 
     DISALLOW_COPY_AND_ASSIGN(Dictionary);
   };
 
   SdchManager();
-  ~SdchManager();
+  virtual ~SdchManager();
 
   // Clear data (for browser data removal).
   void ClearData();
 
   // Record stats on various errors.
   static void SdchErrorRecovery(ProblemCodes problem);
 
   // Register a fetcher that this class can use to obtain dictionaries.
   void set_sdch_fetcher(scoped_ptr<SdchFetcher> fetcher);
 
@@ skipping 46 matching lines @@
   void FetchDictionary(const GURL& request_url, const GURL& dictionary_url);
 
   // Security test function used before initiating a FetchDictionary.
   // Return true if fetch is legal.
   bool CanFetchDictionary(const GURL& referring_url,
                           const GURL& dictionary_url) const;
 
   // Add an SDCH dictionary to our list of availible dictionaries. This addition
   // will fail (return false) if addition is illegal (data in the dictionary is
   // not acceptable from the dictionary_url; dictionary already added, etc.).
-  bool AddSdchDictionary(const std::string& dictionary_text,
-                         const GURL& dictionary_url);
+  // virtual for testing.
+  virtual bool AddSdchDictionary(const std::string& dictionary_text,
+                                 const GURL& dictionary_url);
 
   // Find the vcdiff dictionary (the body of the sdch dictionary that appears
   // after the meta-data headers like Domain:...) with the given |server_hash|
   // to use to decompreses data that arrived as SDCH encoded content.  Check to

[Ryan Sleevi, 2014/09/04 20:06:20]

here

[Randy Smith (Not in Mondays), 2014/09/07 14:09:39]

You skipped several others earlier in the file--if you're going to make me
change things for consistency, no need to restrict yourself to only the code I
haven't edited that shows up for context on Rietveld :-}.  

(I searched for a period followed by two spaces in all files in net/ involved in
this CL; I presume that covers the bases as far as you're concerned, but let me
know if I'm wrong.  I left one ".  " in profile_imple_io_data.cc alone because
it had nothing to do with the code I was touching.)

   // be sure the returned |dictionary| can be used for decoding content supplied
   // in response to a request for |referring_url|.
   // Return null in |dictionary| if there is no matching legal dictionary.
   void GetVcdiffDictionary(const std::string& server_hash,
                            const GURL& referring_url,
                            scoped_refptr<Dictionary>* dictionary);
 
   // Get list of available (pre-cached) dictionaries that we have already loaded
   // into memory.  The list is a comma separated list of (client) hashes per
   // the SDCH spec.
@@ skipping 58 matching lines @@
   ExperimentSet allow_latency_experiment_;
 
   int fetches_count_for_testing_;
 
   DISALLOW_COPY_AND_ASSIGN(SdchManager);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_SDCH_MANAGER_H_