Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 495523002: fix Image::isOpaque test to not leak (Closed)

Created:
6 years, 4 months ago by reed1
Modified:
6 years, 4 months ago
Reviewers:
hal.canary, piotaixr, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fix Image::isOpaque test to not leak BUG=skia: Committed: https://skia.googlesource.com/skia/+/b88813683cb1242ee5d0b6d8f5deb50b39e81e7f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M tests/ImageIsOpaqueTest.cpp View 2 chunks +12 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
reed1
6 years, 4 months ago (2014-08-20 13:59:37 UTC) #1
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-20 13:59:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/495523002/1
6 years, 4 months ago (2014-08-20 14:00:10 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-20 14:00:11 UTC) #4
reed1
6 years, 4 months ago (2014-08-20 14:01:08 UTC) #5
robertphillips
lgtm + a trackability suggestion https://codereview.chromium.org/495523002/diff/1/tests/ImageIsOpaqueTest.cpp File tests/ImageIsOpaqueTest.cpp (right): https://codereview.chromium.org/495523002/diff/1/tests/ImageIsOpaqueTest.cpp#newcode53 tests/ImageIsOpaqueTest.cpp:53: SkAutoTUnref<SkSurface> surfaceOpaque(SkSurface::NewRenderTarget(context, infoOpaque)); Create ...
6 years, 4 months ago (2014-08-20 14:21:49 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 14:24:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as b88813683cb1242ee5d0b6d8f5deb50b39e81e7f

Powered by Google App Engine
This is Rietveld 408576698