Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 495473002: Removing redundant function declaration. (Closed)

Created:
6 years, 4 months ago by Cyan
Modified:
6 years, 4 months ago
Reviewers:
Ted C, Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam, AKVT, AviD
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing redundant function declaration. I'm removing the redundant functions declared in ContentViewCoreImpl class. These functions are private and neither defined nor used anywhere. BUG=NONE. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Cyan
@Ted C,@Yaron PTAL
6 years, 4 months ago (2014-08-20 11:23:23 UTC) #1
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 4 months ago (2014-08-20 17:28:57 UTC) #2
Yaron
lgtm
6 years, 4 months ago (2014-08-20 17:28:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/495473002/1
6 years, 4 months ago (2014-08-20 17:29:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 18:30:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 18:57:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/42182)
6 years, 4 months ago (2014-08-20 18:57:46 UTC) #7
Cyan
The CQ bit was checked by sayan.nayak@samsung.com
6 years, 4 months ago (2014-08-21 09:34:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/495473002/1
6 years, 4 months ago (2014-08-21 09:35:05 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 09:36:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 291028

Powered by Google App Engine
This is Rietveld 408576698