Media Galleries: Cache file info during a directory read to service incoming requests to get file i…

Media Galleries: Cache file info during a directory read to service incoming requests to get file info.

BUG=405710
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291060

[Lei Zhang, 2014-08-20 04:33:16]

I just wrote this and tried it out. IT seems to work very well for my 1000
photos in the DCIM directory test case with Files.app. PTAL. I'll prettify it a
bit tomorrow.

[kinaba, 2014-08-20 05:23:15]

On 2014/08/20 04:33:16, Lei Zhang wrote:
> I just wrote this and tried it out. IT seems to work very well for my 1000
> photos in the DCIM directory test case with Files.app. PTAL. I'll prettify it
a
> bit tomorrow.

lgtm. It should theoretically almost doubles the directory load performance.

[Lei Zhang, 2014-08-20 22:13:13]

Add comments in patch set 2.

[Lei Zhang, 2014-08-20 22:13:15]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-20 22:15:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/495433002/20001

[Lei Zhang, 2014-08-20 22:17:48]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-08-20 22:42:54]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-20 22:45:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/495433002/40001

[kinaba, 2014-08-20 23:10:05]

https://codereview.chromium.org/495433002/diff/40001/chrome/browser/media_gal...
File chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc
(right):

https://codereview.chromium.org/495433002/diff/40001/chrome/browser/media_gal...
chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc:353:
success_callback.Run(info);
Just a comment.

Ah, I didn't fully understand the consequence of this change until I read your
comment in the Bug. So it not just reuse caches but also avoids the task queue
in this cached case. Great. Thanks!

[commit-bot: I haz the power, 2014-08-20 23:48:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[commit-bot: I haz the power, 2014-08-20 23:52:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 23:52:51]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Lei Zhang, 2014-08-20 23:55:43]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-20 23:58:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/495433002/40001

[commit-bot: I haz the power, 2014-08-21 00:14:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[commit-bot: I haz the power, 2014-08-21 00:18:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 00:18:04]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Lei Zhang, 2014-08-21 08:47:11]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-21 08:48:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/495433002/40001

[commit-bot: I haz the power, 2014-08-21 14:21:55]

Committed patchset #3 (40001) as 291060