Issue 495423010: [NaCl SDK] Update build_sdk.py to display Cr-Commit-Position in README.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 495423010: [NaCl SDK] Update build_sdk.py to display Cr-Commit-Position in README. (Closed)

Created:
6 years, 3 months ago by binji

Modified:
6 years, 3 months ago

Reviewers:
bradnelson, bradn, Matt Giuca

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg, Matt Giuca

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Committed: https://crrev.com/6a8b61d6be4656e682eba005a1dd7f129789129c Cr-Commit-Position: refs/heads/master@{#292480}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -17 lines)			Patch
M	native_client_sdk/src/README	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	native_client_sdk/src/build_tools/build_sdk.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/build_tools/build_version.py	View	1	4 chunks	+52 lines, -14 lines	0 comments	Download
M	native_client_sdk/src/tools/getos.py	View		5 chunks	+9 lines, -2 lines	0 comments	Download
M	native_client_sdk/src/tools/tests/getos_test.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

bradn

bradnelson@google.com changed reviewers: + bradnelson@google.com

6 years, 3 months ago (2014-08-28 00:09:54 UTC) #2

Matt Giuca

lgtm, thanks! I'll post a follow-up CL that uses the Cr-Commit-Position in --check-version.

6 years, 3 months ago (2014-08-28 00:13:22 UTC) #4

binji

Committed patchset #2 (id:20001) to pending queue manually as 8549ba4 (presubmit successful).

6 years, 3 months ago (2014-08-28 22:20:35 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:02:51 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/6a8b61d6be4656e682eba005a1dd7f129789129c
Cr-Commit-Position: refs/heads/master@{#292480}