Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 495423004: Cleanup: Remove unneeded references to content_resources.gyp:content_resources. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
brettw, sadrul, kollas, boliu
CC:
chromium-reviews, ozone-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded references to content_resources.gyp:content_resources. TBR=boliu@chromium.org,kolla@chromium.org,sadrul@chromium.org Committed: https://crrev.com/e6ecfd8f595f7df1a9b1ac055851f7bf691dbc9c Cr-Commit-Position: refs/heads/master@{#291758}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/chromecast.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/keyboard/keyboard.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-22 23:42:56 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-24 17:20:21 UTC) #2
Lei Zhang
thestig@chromium.org changed reviewers: + boliu@chromium.org, kolla@chromium.org, sadrul@chromium.org
6 years, 4 months ago (2014-08-25 19:36:55 UTC) #3
Lei Zhang
TBRing remaining owners.
6 years, 4 months ago (2014-08-25 19:37:08 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-25 19:37:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/495423004/20001
6 years, 4 months ago (2014-08-25 19:38:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (20001) as bfbcfc56eaa0829f1b835e4d1aa23e3faccacc78
6 years, 4 months ago (2014-08-25 20:52:51 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:37:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e6ecfd8f595f7df1a9b1ac055851f7bf691dbc9c
Cr-Commit-Position: refs/heads/master@{#291758}

Powered by Google App Engine
This is Rietveld 408576698