Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 495423002: ServiceWorker: CacheStorage.has() message routing fixes (Closed)

Created:
6 years, 4 months ago by jsbell
Modified:
6 years, 4 months ago
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: CacheStorage.has() message routing fixes More copy/pasta. Discovered via pending tests on the Blink side. BUG=392621 TEST=http://crrev.com/430993002 R=jkarlin@chromium.org,gavinp@chromium.org,michaeln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/service_worker/service_worker_cache_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
jsbell
michaeln@ - PTAL?
6 years, 4 months ago (2014-08-22 19:03:05 UTC) #1
michaeln1
lgtm (ooops)
6 years, 4 months ago (2014-08-22 20:15:29 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 4 months ago (2014-08-22 20:24:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/495423002/1
6 years, 4 months ago (2014-08-22 20:25:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 21:20:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 21:22:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/6160)
6 years, 4 months ago (2014-08-22 21:22:49 UTC) #7
michaeln
lgtm2
6 years, 4 months ago (2014-08-22 21:35:56 UTC) #8
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 4 months ago (2014-08-22 21:36:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/495423002/1
6 years, 4 months ago (2014-08-22 21:36:38 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 22:24:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 291529

Powered by Google App Engine
This is Rietveld 408576698