BUILD.gn - Issue 495353003: Move WebMediaPlayerImpl and its dependencies to media/blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 495353003: Move WebMediaPlayerImpl and its dependencies to media/blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Exclude media/blink from Android GN builds for now like cc/blink does. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index b15f69e68328d81a0a0b5aef8c63ca68159f9ff4..0e10fc521e194ac2eaec0b06051cd74232a89d1d 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -48,6 +48,7 @@ group("root") {

"//ipc/mojo",

"//jingle:notifier",

"//media",

+ "//media/blink",

"//media/cast",

"//mojo",

"//net",

@@ -191,6 +192,7 @@ group("root") {

"//extensions/common",

"//extensions/common/api",

"//extensions/renderer",

+ "//media/blink", # Blocked on blink

scherkus (not reviewing) 2014/09/04 23:00:36 nit: looks like they're using two spaces here

acolwell GONE FROM CHROMIUM 2014/09/05 00:23:43 Done.

"//pdf", # Not compiled on Android in GYP yet, either.

"//ppapi:ppapi_c",

"//sandbox",

« no previous file with comments | « no previous file | content/content_renderer.gypi » ('j') | content/content_renderer.gypi » ('J')