Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 495333003: [MIPS] Fix build issue for MIPS (Closed)

Created:
6 years, 4 months ago by petarj
Modified:
6 years, 4 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[MIPS] Fix build issue for MIPS Use double underscore in the preprocessor symbol. Fixes build breakage caused by r291315. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
petarj
PTAL.
6 years, 4 months ago (2014-08-22 14:31:12 UTC) #1
jln (very slow on Chromium)
lgtm, sorry about that.
6 years, 4 months ago (2014-08-22 16:57:58 UTC) #2
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 4 months ago (2014-08-22 17:00:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/495333003/1
6 years, 4 months ago (2014-08-22 17:01:32 UTC) #4
leecam
Apologies, my typo!
6 years, 4 months ago (2014-08-22 17:23:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 17:55:37 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 18:21:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (1) as 291452

Powered by Google App Engine
This is Rietveld 408576698