Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 49533005: Call aura::Env::CreateInstance in ExamplesBrowserMainParts::PreMainMessageLoopRun. (Closed)

Created:
7 years, 1 month ago by msw
Modified:
7 years, 1 month ago
CC:
chromium-reviews, tfarina, sky, dnicoara
Visibility:
Public.

Description

Call aura::Env::CreateInstance in ExamplesBrowserMainParts::PreMainMessageLoopRun. BUG=313848 TEST=views_examples_with_content_exe runs in Win Aura. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msw
Hey Ben, please take a look; thanks!
7 years, 1 month ago (2013-10-31 20:56:17 UTC) #1
Ben Goodger (Google)
lgtm On Thu, Oct 31, 2013 at 1:56 PM, <msw@chromium.org> wrote: > Reviewers: Ben Goodger ...
7 years, 1 month ago (2013-10-31 21:01:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/49533005/1
7 years, 1 month ago (2013-11-05 04:39:33 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 05:12:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/49533005/1
7 years, 1 month ago (2013-11-05 05:32:52 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 13:46:06 UTC) #6
Message was sent while issue was closed.
Change committed as 232962

Powered by Google App Engine
This is Rietveld 408576698