Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2777)

Unified Diff: content/shell/renderer/test_runner/test_runner.cc

Issue 495323003: Remove testRunner.globalFlag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/test_runner/test_runner.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/test_runner/test_runner.cc
diff --git a/content/shell/renderer/test_runner/test_runner.cc b/content/shell/renderer/test_runner/test_runner.cc
index 4362c87b893182d9ea5c9a406d12fb4e533adc52..fe33ffe73ea383cbbaca39baff1485aa8ed75720 100644
--- a/content/shell/renderer/test_runner/test_runner.cc
+++ b/content/shell/renderer/test_runner/test_runner.cc
@@ -292,8 +292,6 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
const std::string& registration_id);
void SetMockPushClientError(const std::string& message);
- bool GlobalFlag();
- void SetGlobalFlag(bool value);
std::string PlatformName();
std::string TooltipText();
bool DisableNotifyDone();
@@ -536,9 +534,6 @@ gin::ObjectTemplateBuilder TestRunnerBindings::GetObjectTemplateBuilder(
&TestRunnerBindings::SetMockPushClientError)
// Properties.
- .SetProperty("globalFlag",
- &TestRunnerBindings::GlobalFlag,
- &TestRunnerBindings::SetGlobalFlag)
.SetProperty("platformName", &TestRunnerBindings::PlatformName)
.SetProperty("tooltipText", &TestRunnerBindings::TooltipText)
.SetProperty("disableNotifyDone", &TestRunnerBindings::DisableNotifyDone)
@@ -1388,17 +1383,6 @@ void TestRunnerBindings::SetMockPushClientError(const std::string& message) {
runner_->SetMockPushClientError(message);
}
-bool TestRunnerBindings::GlobalFlag() {
- if (runner_)
- return runner_->global_flag_;
- return false;
-}
-
-void TestRunnerBindings::SetGlobalFlag(bool value) {
- if (runner_)
- runner_->global_flag_ = value;
-}
-
std::string TestRunnerBindings::PlatformName() {
if (runner_)
return runner_->platform_name_;
@@ -1627,7 +1611,6 @@ void TestRunner::Reset() {
http_headers_to_clear_.clear();
- global_flag_ = false;
platform_name_ = "chromium";
tooltip_text_ = std::string();
disable_notify_done_ = false;
« no previous file with comments | « content/shell/renderer/test_runner/test_runner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698