Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 495223002: GN build rules for all unit test targets in mojo/ (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

GN build rules for all unit test targets in mojo/ R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291373

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix copyright header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -23 lines) Patch
M mojo/BUILD.gn View 2 chunks +10 lines, -0 lines 0 comments Download
A mojo/aura/BUILD.gn View 1 chunk +38 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/mojo_base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 6 chunks +6 lines, -0 lines 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 2 chunks +20 lines, -6 lines 0 comments Download
M mojo/services/BUILD.gn View 2 chunks +9 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 2 chunks +18 lines, -15 lines 0 comments Download
A mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 1 chunk +29 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/view_manager/tests/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
A mojo/services/window_manager/BUILD.gn View 1 chunk +80 lines, -0 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jamesr
6 years, 4 months ago (2014-08-21 21:09:32 UTC) #1
viettrungluu
lgtm w/nit https://codereview.chromium.org/495223002/diff/1/mojo/services/public/cpp/view_manager/lib/BUILD.gn File mojo/services/public/cpp/view_manager/lib/BUILD.gn (right): https://codereview.chromium.org/495223002/diff/1/mojo/services/public/cpp/view_manager/lib/BUILD.gn#newcode1 mojo/services/public/cpp/view_manager/lib/BUILD.gn:1: # Copyright (c) 2014 The Chromium Authors. ...
6 years, 4 months ago (2014-08-21 22:31:29 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-22 05:32:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/495223002/20001
6 years, 4 months ago (2014-08-22 05:33:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 06:28:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 07:27:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1324)
6 years, 4 months ago (2014-08-22 07:27:20 UTC) #7
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-22 07:29:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/495223002/20001
6 years, 4 months ago (2014-08-22 07:29:58 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 10:28:35 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 291373

Powered by Google App Engine
This is Rietveld 408576698