Add tests to make sure copy/paste in an about:blank iframe in a hosted app works.

Add tests to make sure copy/paste in an about:blank iframe in a hosted app or extension works.

BUG=395376
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291268

[not at google - send to devlin, 2014-08-21 20:28:11]

LGTM but I think this patch can be a negative line count :)

https://codereview.chromium.org/495213002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_dom_clipboard_apitest.cc (right):

https://codereview.chromium.org/495213002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_dom_clipboard_apitest.cc:99: return true;
We could save a whole bunch of lines of code here because
ExecuteScriptAndExtractBool basically doesn't fail unless there's something very
wrong. So you should be able to change this method to
(1) ASSERT_TRUE(content::ExecuteScriptAndExtractBool(..))
(2) Return the |result| bool rather than making it an out-param.

Many fewer LOC.

https://codereview.chromium.org/495213002/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/clipboard/extension/test.js (right):

https://codereview.chromium.org/495213002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/clipboard/extension/test.js:35:
chrome.test.fail('execCommand("paste") failed in iframe');
Another line-saver: I don't know why we don't do:

chrome.test.assertEq(true, execCommand(..));

for all of these, rather than those 4 lines.

https://codereview.chromium.org/495213002/diff/20001/chrome/test/data/extensi...
File
chrome/test/data/extensions/api_test/clipboard/extension_no_permission/test.js
(right):

https://codereview.chromium.org/495213002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/clipboard/extension_no_permission/test.js:35:
chrome.test.succeed();
ditto

[Marijn Kruisselbrink, 2014-08-21 20:50:20]

https://codereview.chromium.org/495213002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/extension_dom_clipboard_apitest.cc (right):

https://codereview.chromium.org/495213002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/extension_dom_clipboard_apitest.cc:99: return true;
On 2014/08/21 20:28:11, kalman wrote:
> We could save a whole bunch of lines of code here because
> ExecuteScriptAndExtractBool basically doesn't fail unless there's something
very
> wrong. So you should be able to change this method to
> (1) ASSERT_TRUE(content::ExecuteScriptAndExtractBool(..))
> (2) Return the |result| bool rather than making it an out-param.
> 
> Many fewer LOC.

Done (except with CHECK instead of ASSERT_TRUE as discussed offline).

https://codereview.chromium.org/495213002/diff/20001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/clipboard/extension/test.js (right):

https://codereview.chromium.org/495213002/diff/20001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/clipboard/extension/test.js:35:
chrome.test.fail('execCommand("paste") failed in iframe');
On 2014/08/21 20:28:11, kalman wrote:
> Another line-saver: I don't know why we don't do:
> 
> chrome.test.assertEq(true, execCommand(..));
> 
> for all of these, rather than those 4 lines.
You'd still need chrome.test.succeed() or fail() to cause test.runTests() to
actually go on with the next test. Although always calling succeed after an
assert will still have the desired overall effect, but with confusing output if
the test actually fails.

[Marijn Kruisselbrink, 2014-08-21 20:50:23]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2014-08-21 20:51:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mek@chromium.org/495213002/40001

[commit-bot: I haz the power, 2014-08-21 22:07:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-08-22 00:29:32]

Committed patchset #3 (40001) as 291268

[not at google - send to devlin, 2014-08-22 14:03:13]

https://codereview.chromium.org/495213002/diff/40001/chrome/test/data/extensi...
File chrome/test/data/extensions/api_test/clipboard/extension/test.js (right):

https://codereview.chromium.org/495213002/diff/40001/chrome/test/data/extensi...
chrome/test/data/extensions/api_test/clipboard/extension/test.js:32: if
(ifr.contentDocument.execCommand('paste'))
Ok - I was being a bit silly here. I *would* expect this to work because the
execCommand call is still coming from the same context (this one).

The actual way to trigger an execCommand from a different context would be:

ifr.contentDocument.write('<script>execCommand("copy")</script>')