Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4290)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 495193004: Remove extra from deprecated pageActions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc
diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
index ee1419f4af19e2814e6920fb6037dfe4be3030a6..c1658551237ddd31bdf1946d84a7a10363c2b347 100644
--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc
+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc
@@ -323,12 +323,6 @@ void ExtensionActionAPI::PageActionExecuted(content::BrowserContext* context,
int tab_id,
const std::string& url,
int button) {
- DispatchOldPageActionEvent(context,
- page_action.extension_id(),
- page_action.id(),
- tab_id,
- url,
- button);
WebContents* web_contents = NULL;
if (!ExtensionTabUtil::GetTabById(
tab_id,
@@ -360,27 +354,6 @@ void ExtensionActionAPI::DispatchEventToExtension(
}
// static
-void ExtensionActionAPI::DispatchOldPageActionEvent(
- content::BrowserContext* context,
- const std::string& extension_id,
- const std::string& page_action_id,
- int tab_id,
- const std::string& url,
- int button) {
- scoped_ptr<base::ListValue> args(new base::ListValue());
- args->Append(new base::StringValue(page_action_id));
-
- base::DictionaryValue* data = new base::DictionaryValue();
- data->Set(page_actions_keys::kTabIdKey, new base::FundamentalValue(tab_id));
- data->Set(page_actions_keys::kTabUrlKey, new base::StringValue(url));
- data->Set(page_actions_keys::kButtonKey,
- new base::FundamentalValue(button));
- args->Append(data);
-
- DispatchEventToExtension(context, extension_id, "pageActions", args.Pass());
-}
-
-// static
void ExtensionActionAPI::ExtensionActionExecuted(
content::BrowserContext* context,
const ExtensionAction& extension_action,
« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698