Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 495193004: Remove extra from deprecated pageActions (Closed)

Created:
6 years, 4 months ago by Devlin
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove extra from deprecated pageActions BUG=166959 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291410

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M chrome/browser/extensions/api/extension_action/extension_action_api.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 2 chunks +0 lines, -27 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
Devlin
https://codereview.chromium.org/495193004/diff/1/chrome/browser/extensions/api/extension_action/extension_action_api.cc File chrome/browser/extensions/api/extension_action/extension_action_api.cc (left): https://codereview.chromium.org/495193004/diff/1/chrome/browser/extensions/api/extension_action/extension_action_api.cc#oldcode321 chrome/browser/extensions/api/extension_action/extension_action_api.cc:321: void ExtensionActionAPI::PageActionExecuted(content::BrowserContext* context, I'll clean up the rest of ...
6 years, 4 months ago (2014-08-21 21:44:38 UTC) #1
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-21 21:45:52 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-21 22:55:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/495193004/1
6 years, 4 months ago (2014-08-21 22:59:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-22 00:42:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 00:50:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8285)
6 years, 4 months ago (2014-08-22 00:50:30 UTC) #7
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-22 15:21:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/495193004/1
6 years, 4 months ago (2014-08-22 15:22:11 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 15:30:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 291410

Powered by Google App Engine
This is Rietveld 408576698