build/secondary/tools/grit/grit_rule.gni - Issue 495183002: Fix empty resource IDs file in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/tools/grit/grit_rule.gni

Issue 495183002: Fix empty resource IDs file in GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/tools/grit/grit_rule.gni

diff --git a/build/secondary/tools/grit/grit_rule.gni b/build/secondary/tools/grit/grit_rule.gni

index e1cf53f748c40376711eca0c50c02d63aabb766d..bec147eebbecae844039d305e1600567a0c1040b 100644

--- a/build/secondary/tools/grit/grit_rule.gni

+++ b/build/secondary/tools/grit/grit_rule.gni

@@ -282,7 +282,11 @@ template("grit") {

args = [

"-i", source_path, "build",

- "-f", resource_ids,

+ ]

+ if (resource_ids != "") {

+ args += [ "-f", resource_ids ]

+ }

+ args += [

"-o", rebased_output_dir,

"--depdir", ".",

"--depfile", rebase_path(depfile, root_build_dir),

« no previous file with comments | « no previous file | no next file » | no next file with comments »