Issue 495183002: Fix empty resource IDs file in GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 495183002: Fix empty resource IDs file in GN build. (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix empty resource IDs file in GN build. Previously, if you specified an empty resource ID file in the grit template in the GN build, it would send "-f" with no argument to grit, and this would cause the command line parsing to get messed up and it wouldn't generate any files. This patch just omits the "-f" argument in this case. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291173

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	build/secondary/tools/grit/grit_rule.gni	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 4 months ago (2014-08-21 20:38:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 291173 (presubmit successful).

Expand Messages | Collapse Messages