Issue 495163002: Touch adjustment: don't treat iframes as clickable by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 495163002: Touch adjustment: don't treat iframes as clickable by default (Closed)

Created:
6 years, 4 months ago by Rick Byers

Modified:
6 years, 4 months ago

Reviewers:
Zeeshan Qureshi

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Touch adjustment: don't treat iframes as clickable by default Iframe elements are hard-coded to be focusable, but unlike other focusable elements (like text fields) this is almost always invisible to the user. This disables the 'is focusable' check for the special case of iframes. Iframes can still be candidates for adjustment for other reasons (eg. event handlers), as can their contents of course. BUG=405999 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180778

Patch Set 1 #

Patch Set 2 : Update hit test counts #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
M	LayoutTests/fast/events/hit-test-counts-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/events/touch/gesture/gesture-tap-near-iframe-expected.txt	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/page/TouchAdjustment.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/495163002/20001

6 years, 4 months ago (2014-08-22 14:28:25 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-22 15:26:37 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-22 15:34:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 180778

Expand Messages | Collapse Messages