Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: build/android/provision_devices.py

Issue 495123002: [Android] Fix provisioning for perf bots on L and/or user builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/provision_devices.py
diff --git a/build/android/provision_devices.py b/build/android/provision_devices.py
index b5981d9a39ffab3eb1b8ac3bba2fc0483e1882c1..54c90c3a6eef8e652f02f5ed34041e5201ce6553 100755
--- a/build/android/provision_devices.py
+++ b/build/android/provision_devices.py
@@ -140,7 +140,8 @@ def WipeDeviceIfPossible(device):
try:
device.EnableRoot()
jbudorick 2014/08/21 17:15:15 @tonyg: it'll skip the wipe here. if we can't enab
WipeDeviceData(device)
- device.Reboot(True, timeout=180, retries=0)
+ # TODO(jbudorick): Tune the timeout per OS version.
+ device.Reboot(True, timeout=600, retries=0)
except (errors.DeviceUnresponsiveError, device_errors.CommandFailedError):
pass
@@ -149,7 +150,10 @@ def ProvisionDevice(device, options, is_perf):
try:
if not options.skip_wipe:
WipeDeviceIfPossible(device)
- device.EnableRoot()
+ try:
+ device.EnableRoot()
tonyg 2014/08/21 17:12:58 I think the old code would skip the wipe if we cou
+ except device_errors.CommandFailedError as e:
+ logging.warning(str(e))
_ConfigureLocalProperties(device, is_perf)
device_settings.ConfigureContentSettings(
device, device_settings.DETERMINISTIC_DEVICE_SETTINGS)
@@ -187,7 +191,8 @@ def ProvisionDevice(device, options, is_perf):
time.sleep(60)
battery_info = device.old_interface.GetBatteryInfo()
device.RunShellCommand('date -u %f' % time.time(), as_root=True)
- device.Reboot(True, timeout=180, retries=0)
+ # TODO(jbudorick): Tune the timeout per OS version.
+ device.Reboot(True, timeout=600, retries=0)
props = device.RunShellCommand('getprop')
for prop in props:
logging.info(' %s' % prop)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698