|
|
Created:
6 years, 4 months ago by Arnar Birgisson Modified:
6 years, 4 months ago CC:
chromium-reviews, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionTolerate that CMD_SYNC does not exist (per U2F spec).
BUG=405904
R=mschilder,juanlang,xiyuan
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291351
Patch Set 1 #
Messages
Total messages: 18 (0 generated)
Marius, Juan, here's a backport of the CMD_SYNC fix. I don't have devices with differing versions to test here in ZRH, are you able to patch this in and test manually? Xiyuan, this is a bug-fix that we'll be requesting to merge.
lgtm
lgtm
The CQ bit was checked by mschilder@google.com
lgtm cq already
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/495033002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
The CQ bit was checked by juanlang@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/495033002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
The CQ bit was checked by juanlang@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/495033002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
Message was sent while issue was closed.
Committed patchset #1 (1) as 291351 |