Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 495033002: Tolerate that CMD_SYNC does not exist (per U2F spec). (Closed)

Created:
6 years, 4 months ago by Arnar Birgisson
Modified:
6 years, 4 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Tolerate that CMD_SYNC does not exist (per U2F spec). BUG=405904 R=mschilder,juanlang,xiyuan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/cryptotoken/gnubby.js View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Arnar Birgisson
Marius, Juan, here's a backport of the CMD_SYNC fix. I don't have devices with differing ...
6 years, 4 months ago (2014-08-21 13:36:09 UTC) #1
xiyuan
lgtm
6 years, 4 months ago (2014-08-21 15:33:40 UTC) #2
Marius
lgtm
6 years, 4 months ago (2014-08-21 15:37:47 UTC) #3
Marius
The CQ bit was checked by mschilder@google.com
6 years, 4 months ago (2014-08-21 20:25:11 UTC) #4
Marius
lgtm cq already
6 years, 4 months ago (2014-08-21 20:26:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/495033002/1
6 years, 4 months ago (2014-08-21 20:28:48 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 22:07:39 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 22:19:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8194)
6 years, 4 months ago (2014-08-21 22:19:45 UTC) #9
juanlang (chromium.org)
The CQ bit was checked by juanlang@chromium.org
6 years, 4 months ago (2014-08-21 22:20:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/495033002/1
6 years, 4 months ago (2014-08-21 22:22:31 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 22:45:09 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 22:47:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8215)
6 years, 4 months ago (2014-08-21 22:47:29 UTC) #14
juanlang (chromium.org)
The CQ bit was checked by juanlang@chromium.org
6 years, 4 months ago (2014-08-22 03:14:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arnarb@chromium.org/495033002/1
6 years, 4 months ago (2014-08-22 03:15:41 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 03:20:01 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 07:25:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (1) as 291351

Powered by Google App Engine
This is Rietveld 408576698