Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 495003003: Supervised user interstitial: Handle missing custodian profile URL. (Closed)

Created:
6 years, 4 months ago by Marc Treib
Modified:
6 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Supervised user interstitial: Handle missing custodian profile URL. Followup to https://codereview.chromium.org/483703002/ Turns out you can have a profile image, but no profile URL. Handle this case by resolving the image URL against a dummy https URL. BUG=404671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291153

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/browser/supervised_user/supervised_user_interstitial.cc View 1 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Marc Treib
PTAL!
6 years, 4 months ago (2014-08-21 09:51:30 UTC) #1
Bernhard Bauer
LGTM w/ a nit: https://codereview.chromium.org/495003003/diff/1/chrome/browser/supervised_user/supervised_user_interstitial.cc File chrome/browser/supervised_user/supervised_user_interstitial.cc (right): https://codereview.chromium.org/495003003/diff/1/chrome/browser/supervised_user/supervised_user_interstitial.cc#newcode151 chrome/browser/supervised_user/supervised_user_interstitial.cc:151: GURL profile_url = GURL(profile->GetPrefs()->GetString( Could ...
6 years, 4 months ago (2014-08-21 14:48:46 UTC) #2
Marc Treib
https://codereview.chromium.org/495003003/diff/1/chrome/browser/supervised_user/supervised_user_interstitial.cc File chrome/browser/supervised_user/supervised_user_interstitial.cc (right): https://codereview.chromium.org/495003003/diff/1/chrome/browser/supervised_user/supervised_user_interstitial.cc#newcode151 chrome/browser/supervised_user/supervised_user_interstitial.cc:151: GURL profile_url = GURL(profile->GetPrefs()->GetString( On 2014/08/21 14:48:46, Bernhard Bauer ...
6 years, 4 months ago (2014-08-21 15:59:08 UTC) #3
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-08-21 15:59:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/495003003/20001
6 years, 4 months ago (2014-08-21 16:01:19 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 19:20:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291153

Powered by Google App Engine
This is Rietveld 408576698