Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 495003002: Video Player: Show appropriate message on playing unsupported video (Closed)

Created:
6 years, 4 months ago by yoshiki
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Video Player: Show appropriate message on playing unsupported video Show "This video could not be loaded" error on playing unsupported video. BUG=405860 TEST=manually testted Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M ui/file_manager/video_player/js/video_player.js View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
yoshiki
@hirono, PTAL. Thanks.
6 years, 4 months ago (2014-08-21 10:11:16 UTC) #1
hirono
lgtm
6 years, 4 months ago (2014-08-22 03:58:48 UTC) #2
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 4 months ago (2014-08-22 03:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/495003002/1
6 years, 4 months ago (2014-08-22 04:00:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 04:55:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 05:46:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1286)
6 years, 4 months ago (2014-08-22 05:46:46 UTC) #7
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 4 months ago (2014-08-22 07:20:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/495003002/1
6 years, 4 months ago (2014-08-22 07:26:33 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 08:26:53 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 10:25:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 291371

Powered by Google App Engine
This is Rietveld 408576698