Issue 494993004: Move external popup menus from WebViewClient to WebFrameClient, part 1/3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 494993004: Move external popup menus from WebViewClient to WebFrameClient, part 1/3. (Closed)

Created:
6 years, 4 months ago by Avi (use Gerrit)

Modified:
6 years, 4 months ago

Reviewers:
nasko

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Move external popup menus from WebViewClient to WebFrameClient, part 1/3. BUG=304341 TEST=popup menus still work Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291280

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	content/renderer/render_frame_impl.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
	M	content/renderer/render_frame_impl.cc	View		3 chunks	+10 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/494993004/1

6 years, 4 months ago (2014-08-21 21:36:43 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-21 22:43:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 291280