mojo/public/cpp/bindings/lib/validation_errors.cc - Issue 494943004: Mojo C++ bindings: better log messages for some validation errors at the receiver side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/validation_errors.cc

Issue 494943004: Mojo C++ bindings: better log messages for some validation errors at the receiver side. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/lib/validation_errors.h ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/lib/validation_errors.cc

diff --git a/mojo/public/cpp/bindings/lib/validation_errors.cc b/mojo/public/cpp/bindings/lib/validation_errors.cc

index e3ce6d6ab785de863bd2229ed770ea45013cde79..61f233f8d32e169eebb407b5103da0ae6fc370cb 100644

--- a/mojo/public/cpp/bindings/lib/validation_errors.cc

+++ b/mojo/public/cpp/bindings/lib/validation_errors.cc

@@ -44,11 +44,15 @@ const char* ValidationErrorToString(ValidationError error) {

return "Unknown error";

}

-void ReportValidationError(ValidationError error) {

- if (g_validation_error_observer)

+void ReportValidationError(ValidationError error, const char* description) {

+ if (g_validation_error_observer) {

g_validation_error_observer->set_last_error(error);

- else

+ } else if (description) {

+ MOJO_LOG(ERROR) << "Invalid message: " << ValidationErrorToString(error)

+ << " (" << description << ")";

+ } else {

MOJO_LOG(ERROR) << "Invalid message: " << ValidationErrorToString(error);

+ }

}

ValidationErrorObserverForTesting::ValidationErrorObserverForTesting()