LayoutTests/fast/events/resources/mouse-events-within-no-element-iframe.html - Issue 494913003: Mousemove event should be fired when the mouse stays in the document but there is no element.

Side by Side Diff: LayoutTests/fast/events/resources/mouse-events-within-no-element-iframe.html

Issue 494913003: Mousemove event should be fired when the mouse stays in the document but there is no element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <style type="text/css">

	4 html, body, .workspace{

	5 height: 100%;

	6 }

	7 button {

	8 cursor: pointer;

	9 padding: 0px;

	10 margin: 0px;

	11 }

	12 .minbox {

	13 height: 30px;

	14 width: 1px;

	15 }

	16 #div1, #div2 {

	17 height: 80px;

	18 border: 1px solid #aaaaaa;

	19 }

	20 </style>

	21 </head>

	22 <body>

	23 <div class="workspace"></div>

	24 <div class="minbox">

	25 <div id="test">

	26 <button>POINTER</button>

	27 </div>

	28 </div>

	29 <script>
	Julien - ping for review 2014/09/08 20:07:41 This test is super difficult to analyze for severa This test is super difficult to analyze for several reasons: - you're dumping only the target but we don't know which frame they belong to (main frame, iframe?). - you're using ALERT, which I would recommend to avoid, prefer a console element. Alternatively console.log but I prefer some DOM dumping. - mostly, you don't describe what you're testing (description) and what a failing / passing output would look like (expectations). Miyoung Shin(g) 2014/09/11 23:53:28 I'm changing the test case but there is a flaky is Show quoted text On 2014/09/08 20:07:41, Julien Chaffraix - PST wrote: > This test is super difficult to analyze for several reasons: > - you're dumping only the target but we don't know which frame they belong to > (main frame, iframe?). I'm changing the test case but there is a flaky issue and I'm analyzing it. it's taking longer than I thought. Anyway, I will change it to dumpChildFramesAsText to be easy to know. Show quoted text > - you're using ALERT, which I would recommend to avoid, prefer a console > element. Alternatively console.log but I prefer some DOM dumping. I will change ALERT to shouldBexxxxx Show quoted text > - mostly, you don't describe what you're testing (description) and what a > failing / passing output would look like (expectations). I will add the description in the test case.
	30 function eventHandler(e) {

	31 alert(e.type + " : " + e.currentTarget);

	32 };

	33 window.scrollBy(0, 200);

	34 if (window.testRunner) {

	35 var div = document.getElementById("test");

	36 var x = div.offsetLeft;

	37 var y = div.offsetTop-window.pageYOffset+10;

	38 x=x+200;
	Julien - ping for review 2014/09/08 20:07:41 You did a good job at following Blink's style belo You did a good job at following Blink's style below so these 2 lines should also follow it for consistency. Miyoung Shin(g) 2014/09/11 23:53:28 I will fix it. Show quoted text On 2014/09/08 20:07:41, Julien Chaffraix - PST wrote: > You did a good job at following Blink's style below so these 2 lines should also > follow it for consistency. I will fix it.
	39

	40 document.addEventListener("mousemove", eventHandler);

	41 document.body.addEventListener("mousemove", eventHandler);

	42 eventSender.mouseMoveTo(x, y);

	43 eventSender.mouseMoveTo(x, y + 100);

	44 eventSender.mouseMoveTo(x, y - 100);

	45 eventSender.mouseMoveTo(x, y + 100);

	46 document.removeEventListener("mousemove", eventHandler, false);

	47 document.body.removeEventListener("mousemove", eventHandler, false);

	48

	49 document.addEventListener("mouseover", eventHandler);

	50 eventSender.mouseMoveTo(x, y);

	51 eventSender.mouseMoveTo(x, y + 100);

	52 document.removeEventListener("mouseover", eventHandler, false);

	53

	54 document.addEventListener("mouseout", eventHandler);

	55 eventSender.mouseMoveTo(x, y);

	56 eventSender.mouseMoveTo(x, y + 100);

	57 document.removeEventListener("mouseout", eventHandler, false);

	58

	59 document.addEventListener("mouseenter", eventHandler);

	60 document.addEventListener("mouseleave", eventHandler);

	61 document.body.addEventListener("mouseenter", eventHandler);

	62 document.body.addEventListener("mouseleave", eventHandler);

	63 eventSender.mouseMoveTo(x, y);

	64 eventSender.mouseMoveTo(x, y + 100);

	65 eventSender.mouseMoveTo(x, y - 100);

	66 eventSender.mouseMoveTo(x, y + 100);

	67

	68 testRunner.dumpAsText();

	69 }

	70 </script>

	71 </body>

	72 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/events/mouse-events-within-no-element-expected.txt ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »