Include better OpenSSL error information in NetLog.

net/socket/ssl_client_socket_openssl.cc

Index: net/socket/ssl_client_socket_openssl.cc
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index ed1138f50dd4e08c89fe76ff7a38a29328f6e24a..71ea6dac7e740845435fbfc10118a54f9ba8416b 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -24,7 +24,6 @@
 #include "net/cert/single_request_cert_verifier.h"
 #include "net/cert/x509_certificate_net_log_param.h"
 #include "net/http/transport_security_state.h"
-#include "net/socket/ssl_error_params.h"
 #include "net/socket/ssl_session_cache_openssl.h"
 #include "net/ssl/openssl_ssl_util.h"
 #include "net/ssl/ssl_cert_request_info.h"
@@ -909,7 +908,11 @@ int SSLClientSocketOpenSSL::DoHandshake() {
       return OK;
     }
 
-    net_error = MapOpenSSLError(ssl_error, err_tracer);
+    uint32_t error_code;
+    const char* file;
+    int line;
+    net_error = MapOpenSSLErrorWithDetails(
+        ssl_error, err_tracer, &error_code, &file, &line);

[Ryan Sleevi, 2014/08/25 06:24:35]

Rather than having to create the three local variables and trade them, does it
make more sense to marshal this into a simple struct and bind the callback to
that struct?

[davidben, 2014/08/26 22:13:51]

Done.

 
     // If not done, stay in this state
     if (net_error == ERR_IO_PENDING) {
@@ -920,7 +923,8 @@ int SSLClientSocketOpenSSL::DoHandshake() {
                  << ", net_error " << net_error;
       net_log_.AddEvent(
           NetLog::TYPE_SSL_HANDSHAKE_ERROR,
-          CreateNetLogSSLErrorCallback(net_error, ssl_error));
+          CreateNetLogOpenSSLErrorCallback(
+              net_error, ssl_error, error_code, file, line));
     }
   }
   return net_error;