Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issue 494883002: Null out context_factory in window_tree_host on shutdown (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Null out context_factory in window_tree_host on shutdown A context factory is specific to a particular native viewport so we shouldn't leak it between different WindowTreeHostImpl instances. This fixes some crashes in mojo_view_manager_unittests. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291196

Patch Set 1 #

Patch Set 2 : remove debugging LOG(ERROR) that slipped in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/services/view_manager/window_tree_host_impl.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
jamesr
6 years, 4 months ago (2014-08-20 21:30:57 UTC) #1
sky
LGTM
6 years, 4 months ago (2014-08-20 21:37:54 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-20 21:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/494883002/1
6 years, 4 months ago (2014-08-20 21:40:42 UTC) #4
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-20 21:41:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/494883002/20001
6 years, 4 months ago (2014-08-20 21:42:25 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 23:07:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 23:12:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55234) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/8008)
6 years, 4 months ago (2014-08-20 23:12:06 UTC) #9
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-21 20:27:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/494883002/20001
6 years, 4 months ago (2014-08-21 20:31:40 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:34:55 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291196

Powered by Google App Engine
This is Rietveld 408576698