Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 494863003: Make SkPMColorAssert a macro (all assert-like functions should be macros). (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make SkPMColorAssert a macro (all assert-like functions should be macros). Committed: https://skia.googlesource.com/skia/+/af28dc6030ebb3007f7968b3d5d16637284d254a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M include/core/SkColorPriv.h View 1 chunk +9 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hal.canary
possibly useful
6 years, 4 months ago (2014-08-20 21:55:45 UTC) #1
reed1
lgtm
6 years, 4 months ago (2014-08-20 22:03:02 UTC) #2
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-21 13:22:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/494863003/1
6 years, 4 months ago (2014-08-21 13:23:30 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 13:30:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as af28dc6030ebb3007f7968b3d5d16637284d254a

Powered by Google App Engine
This is Rietveld 408576698