Issue 494853004: Move guest_view_internal_api to extensions.

Issue 494853004: Move guest_view_internal_api to extensions. (Closed)

Created:
6 years, 3 months ago by Xi Han

Modified:
6 years, 3 months ago

Reviewers:
Fady Samuel, Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, wjmaclean, lfg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Move guest_view_internal_api to extensions. BUG=352293 Committed: https://crrev.com/9780c0f736cdb9b1b05d3ab06e12ffaae9e91c15 Cr-Commit-Position: refs/heads/master@{#292640}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -235 lines)			Patch
D	chrome/browser/extensions/api/guest_view/guest_view_internal_api.h	View		1 chunk	+0 lines, -44 lines	0 comments	Download
D	chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc	View		1 chunk	+0 lines, -94 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/common/extensions/api/guest_view_internal.json	View		1 chunk	+0 lines, -86 lines	0 comments	Download
M	chrome/common/extensions/api/schemas.gypi	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
A +	extensions/browser/api/guest_view/OWNERS	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	extensions/browser/api/guest_view/guest_view_internal_api.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	extensions/browser/api/guest_view/guest_view_internal_api.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
A	extensions/common/api/OWNERS	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	extensions/common/api/guest_view_internal.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/common/api/schemas.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/extensions.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 11 (0 generated)

Xi Han

hanxi@chromium.org changed reviewers: + fsamuel@chromium.org

6 years, 3 months ago (2014-08-27 22:24:48 UTC) #1

Xi Han

hanxi@chromium.org changed reviewers: + rockot@chromium.org

6 years, 3 months ago (2014-08-28 12:30:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hanxi@chromium.org/494853004/40001

6 years, 3 months ago (2014-08-29 13:23:18 UTC) #8

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...

6 years, 3 months ago (2014-08-29 14:43:05 UTC) #9

commit-bot: I haz the power

Committed patchset #3 (id:40001) as 3bb1880107e77819bf60d4de5276fffc42adbc5b

6 years, 3 months ago (2014-08-29 15:51:40 UTC) #10

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:08:52 UTC) #11

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/9780c0f736cdb9b1b05d3ab06e12ffaae9e91c15
Cr-Commit-Position: refs/heads/master@{#292640}