events: keycodes: Remove the stateless singleton instance of KeycodeConverter

events: keycodes: Remove the stateless singleton instance of KeycodeConverter

All methods can be safely made static and the singleton
removed.

TBR=ben@chromium.org

Committed: https://crrev.com/ba8794f64adbbfc8f92327b632dad034de408726
Cr-Commit-Position: refs/heads/master@{#292070}

[spang, 2014-08-26 23:11:17]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-08-26 23:13:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/spang@chromium.org/494813002/40001

[commit-bot: I haz the power, 2014-08-27 00:37:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[commit-bot: I haz the power, 2014-08-27 01:32:56]

Committed patchset #3 (40001) as 2547dc3aa05b24cb9238df365dcb4584dbed14c4

[Wez, 2014-08-31 01:27:38]

This patch set appears to have been committed without actually having been
reviewed...?

[spang, 2014-08-31 07:40:57]

On 2014/08/31 01:27:38, Wez wrote:
> This patch set appears to have been committed without actually having been
> reviewed...?

Sorry, I submitted TBR as this fixed a build issue in a different CL - some
dynamic annotations linkage error. I didn't want to block that CL that for a
long period waiting to submit something trivial.

[chromium-reviews, 2014-08-31 17:29:53]

Sorry, but rushing through work to unblock another CL is not an appropriate
use of TBR.
On 31 Aug 2014 00:40, <spang@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> On 2014/08/31 01:27:38, Wez wrote:
>
>> This patch set appears to have been committed without actually having been
>> reviewed...?
>>
>
> Sorry, I submitted TBR as this fixed a build issue in a different CL - some
> dynamic annotations linkage error. I didn't want to block that CL that for
> a
> long period waiting to submit something trivial.
>
> Description:
> events: keycodes: Remove the stateless singleton instance of
> KeycodeConverter
>
> All methods can be safely made static and the singleton
> removed.
>
> TBR=ben@chromium.org
>
> Committed:
> https://chromium.googlesource.com/chromium/src/+/
> 2547dc3aa05b24cb9238df365dcb4584dbed14c4
>
> Please review this at https://codereview.chromium.org/494813002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+114, -134 lines):
>   M chrome/browser/chromeos/input_method/input_method_engine.cc
>   M content/public/test/browser_test_utils.cc
>   M content/renderer/pepper/usb_key_code_conversion_linux.cc
>   M content/renderer/pepper/usb_key_code_conversion_mac.cc
>   M content/renderer/pepper/usb_key_code_conversion_win.cc
>   M remoting/client/plugin/pepper_input_handler.cc
>   M remoting/host/input_injector_linux.cc
>   M remoting/host/input_injector_mac.cc
>   M remoting/host/input_injector_win.cc
>   M ui/events/event_unittest.cc
>   M ui/events/keycodes/dom4/keycode_converter.h
>   M ui/events/keycodes/dom4/keycode_converter.cc
>   M ui/events/keycodes/dom4/keycode_converter_unittest.cc
>   M ui/events/keycodes/keyboard_code_conversion_mac.mm
>   M ui/events/keycodes/keyboard_code_conversion_win.cc
>   M ui/events/keycodes/keyboard_code_conversion_x.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-09-10 02:48:49]

Patchset 3 (id:??) landed as
https://crrev.com/ba8794f64adbbfc8f92327b632dad034de408726
Cr-Commit-Position: refs/heads/master@{#292070}