Issue 494773003: Move shouldSmoothFonts out of GraphicsContextState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 494773003: Move shouldSmoothFonts out of GraphicsContextState. (Closed)

Created:
6 years, 4 months ago by f(malita)

Modified:
6 years, 4 months ago

Reviewers:
Stephen Chennney, Stephen White, jbroman

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, reed1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Move shouldSmoothFonts out of GraphicsContextState. The flag is an invariant GraphicsContext property (only set once, at construction time) and doesn't need to be saved/restored as part of GraphicsContextState. R=schenney@chromium.org,senorblanco@chromium.org,jbroman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180735

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -8 lines)			Patch
M	Source/platform/graphics/GraphicsContext.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/platform/graphics/GraphicsContext.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/graphics/GraphicsContextState.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/platform/graphics/GraphicsContextState.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

jbroman

lgtm I do like the idea of moving some of these setters that don't forward ...

6 years, 4 months ago (2014-08-21 19:44:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/494773003/1

6 years, 4 months ago (2014-08-21 19:50:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 180735