Quick-reject draw text blob calls.

Quick-reject draw text blob calls.

R=reed@google.com,robertphillips@google.com,mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/7ba7aa7e82c749b0b794f85b546f588ccf2ca777

[f(malita), 2014-08-27 17:06:51]

We'll need to add implicit blob bounds calculation before this can land.

[reed1, 2014-08-27 17:16:23]

https://codereview.chromium.org/494763004/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/494763004/diff/1/src/core/SkCanvas.cpp#newcod...
src/core/SkCanvas.cpp:2228: // FIXME: dispatch to the device instead
I don't think the device needs to do this.

However, I think we do need to invoke the paint in the rejecting process (e.g.
computeFastBounds). See other sites like path.

[robertphillips, 2014-08-27 17:25:30]

https://codereview.chromium.org/494763004/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/494763004/diff/1/src/core/SkCanvas.cpp#newcod...
src/core/SkCanvas.cpp:2228: // FIXME: dispatch to the device instead
The GPU device wants this.

[f(malita), 2014-08-27 17:55:44]

https://codereview.chromium.org/494763004/diff/1/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/494763004/diff/1/src/core/SkCanvas.cpp#newcod...
src/core/SkCanvas.cpp:2228: // FIXME: dispatch to the device instead
On 2014/08/27 17:16:22, reed1 wrote:
> However, I think we do need to invoke the paint in the rejecting process (e.g.
> computeFastBounds). See other sites like path.

Done.

[f(malita), 2014-08-28 15:15:28]

Tweaked to only quick-reject non-empty bounds (makes the GM happy). PTAL.

This allows us to land the optimization independent of implicit bounds support.
Blink always uses explicit bounds, and we can remove the exception once implicit
bounds are implemented.

[robertphillips, 2014-08-29 15:19:55]

lgtm

[reed1, 2014-08-29 15:34:28]

https://codereview.chromium.org/494763004/diff/80001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/494763004/diff/80001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:2228: SkRect storage;
I wonder if we should send the translated rect to the paint, in case it has an
imagefilter or something?

https://codereview.chromium.org/494763004/diff/80001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:2246: this->translate(x, y);
Eeeek! translate is virtual. I thought all of this old code was now safely
inside SkBaseDevice?

[f(malita), 2014-08-29 15:36:39]

https://codereview.chromium.org/494763004/diff/80001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/494763004/diff/80001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:2246: this->translate(x, y);
On 2014/08/29 15:34:28, reed1 wrote:
> Eeeek! translate is virtual. I thought all of this old code was now safely
> inside SkBaseDevice?

It is now, just haven't rebased this yet :)

[f(malita), 2014-08-29 16:01:26]

https://codereview.chromium.org/494763004/diff/80001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/494763004/diff/80001/src/core/SkCanvas.cpp#ne...
src/core/SkCanvas.cpp:2228: SkRect storage;
On 2014/08/29 15:34:28, reed1 wrote:
> I wonder if we should send the translated rect to the paint, in case it has an
> imagefilter or something?

Done.

[reed1, 2014-08-29 16:22:56]

https://codereview.chromium.org/494763004/diff/100001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/494763004/diff/100001/src/core/SkCanvas.cpp#n...
src/core/SkCanvas.cpp:2226: const SkRect *bounds = &blob->bounds();
Do we need local "bounds" or the if (x || y)?

computeFast(blob->bounds().makeOffset(x, y), &storage)

[f(malita), 2014-08-29 16:32:01]

https://codereview.chromium.org/494763004/diff/100001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (right):

https://codereview.chromium.org/494763004/diff/100001/src/core/SkCanvas.cpp#n...
src/core/SkCanvas.cpp:2226: const SkRect *bounds = &blob->bounds();
On 2014/08/29 16:22:56, reed1 wrote:
> Do we need local "bounds" or the if (x || y)?
> 
> computeFast(blob->bounds().makeOffset(x, y), &storage)

Only if we want to avoid initializing a "translated" rect when no offset. But
OK, probably not worth it. Done.

[reed1, 2014-08-29 16:33:46]

simplicity unless forced into other

lgtm

[f(malita), 2014-08-29 16:37:41]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-08-29 16:38:05]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/494763004/120001

[commit-bot: I haz the power, 2014-08-29 16:46:41]

Committed patchset #7 (id:120001) as 7ba7aa7e82c749b0b794f85b546f588ccf2ca777