Issue 494743002: Make the fullscreen element ready check static

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 494743002: Make the fullscreen element ready check static (Closed)

Created:
6 years, 4 months ago by philipj_slow

Modified:
6 years, 4 months ago

Reviewers:
falken

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Make the fullscreen element ready check static Also, use Element instead of HTMLFrameOwnerElement. BUG=402376 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180692

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -44 lines)			Patch
	M	Source/core/dom/Fullscreen.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/dom/Fullscreen.cpp	View		4 chunks	+42 lines, -42 lines	0 comments	Download

Total messages: 5 (0 generated)

philipj_slow

PTAL and CQ if no nits. (Please forgive the piggybacking.)

6 years, 4 months ago (2014-08-20 15:31:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/494743002/1

6 years, 4 months ago (2014-08-21 02:01:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180692