Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 494733005: Change return-type of SetDataProperty to Handle. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Change return-type of SetDataProperty to Handle. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/objects.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-22 11:02:56 UTC) #1
Yang
On 2014/08/22 11:02:56, Toon Verwaest wrote: > PTAL lgtm.
6 years, 4 months ago (2014-08-22 11:22:55 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-22 11:48:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23307 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698