Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: tools/git-sync-deps

Issue 494713005: git-sync-deps: handle recursion and deps_os at the same time (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/git-sync-deps
diff --git a/tools/git-sync-deps b/tools/git-sync-deps
index 717ab38055287dc2af9a0bdb4c814fcdca51fb79..b21b941c85682320e22ba1750caa749e0d3b4eb2 100755
--- a/tools/git-sync-deps
+++ b/tools/git-sync-deps
@@ -172,14 +172,12 @@ def git_sync_deps(deps_file_path, deps_os_list, verbose):
deps_file_directory = os.path.dirname(deps_file_path)
deps = parse_file_to_dict(deps_file_path)
dependencies = deps['deps'].copy()
- for deps_os in deps_os_list:
- # Add OS-specific dependencies
- if deps_os not in deps['deps_os']:
- raise DepsError(
- 'Argument "%s" not found within deps_os keys %r' %
- (deps_os, deps['deps_os'].keys()))
- for dep in deps['deps_os'][deps_os]:
- dependencies[dep] = deps['deps_os'][deps_os][dep]
+ if 'deps_os' in deps:
+ for deps_os in deps_os_list:
mtklein 2014/08/26 18:44:27 deps_os -> os; deps_os_list -> command_line_os_re
+ # Add OS-specific dependencies
+ if deps_os in deps['deps_os']:
mtklein 2014/08/26 18:44:27 deps -> deps_file
+ for dep in deps['deps_os'][deps_os]:
+ dependencies[dep] = deps['deps_os'][deps_os][dep]
mtklein 2014/08/26 18:44:27 dependencies.update(deps['deps_os'][deps_os])
list_of_arg_lists = []
for directory in dependencies:
if '@' in dependencies[directory]:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698