git-sync-deps: handle recursion and deps_os at the same time

git-sync-deps: handle recursion and deps_os at the same time

NOTRY=true

Committed: https://skia.googlesource.com/skia/+/c6c0624cb69caf310b0e9d935b8f64ac0729fd5e

[hal.canary, 2014-08-26 18:30:06]

halcanary@google.com changed reviewers:
+ borenet@google.com, mtklein@google.com

[hal.canary, 2014-08-26 18:30:06]

PTAL

[mtklein, 2014-08-26 18:44:27]

https://codereview.chromium.org/494713005/diff/1/tools/git-sync-deps
File tools/git-sync-deps (right):

https://codereview.chromium.org/494713005/diff/1/tools/git-sync-deps#newcode176
tools/git-sync-deps:176: for deps_os in deps_os_list:
deps_os -> os;

deps_os_list -> command_line_os_requests

https://codereview.chromium.org/494713005/diff/1/tools/git-sync-deps#newcode178
tools/git-sync-deps:178: if deps_os in deps['deps_os']:
deps -> deps_file

https://codereview.chromium.org/494713005/diff/1/tools/git-sync-deps#newcode180
tools/git-sync-deps:180: dependencies[dep] = deps['deps_os'][deps_os][dep]
dependencies.update(deps['deps_os'][deps_os])

[hal.canary, 2014-08-26 18:54:18]

changed

[mtklein, 2014-08-26 18:58:36]

lgtm

https://codereview.chromium.org/494713005/diff/20001/tools/git-sync-deps
File tools/git-sync-deps (right):

https://codereview.chromium.org/494713005/diff/20001/tools/git-sync-deps#newc...
tools/git-sync-deps:163: deps_os_list (list of strings) Can be empty list.  List
of
update?

[hal.canary, 2014-08-26 19:03:49]

Patchset #3 (id:40001) has been deleted

[hal.canary, 2014-08-26 19:05:43]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-08-26 19:06:43]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/halcanary@google.com/494713005/60001

[commit-bot: I haz the power, 2014-08-26 19:06:52]

Committed patchset #3 (60001) as c6c0624cb69caf310b0e9d935b8f64ac0729fd5e