git_cl.py - Issue 494713003: Have git-cl try fail when used on a closed CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 494713003: Have git-cl try fail when used on a closed CL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 75b479664c1989ef053c8d283177e59985f897fe..82e9208632860decd8ad16c546eb57e433f6482e 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -2303,6 +2303,9 @@ def CMDtry(parser, args):

parser.error('Need to upload first')

props = cl.GetIssueProperties()

+ if props.get('closed'):

+ parser.error('Cannot send tryjobs for a closed CL')

if props.get('private'):

parser.error('Cannot use trybots with private issue')

« no previous file with comments | « no previous file | no next file » | no next file with comments »